Closed Bug 1390721 Opened 8 years ago Closed 8 years ago

Add a message when no fonts are found for the currently selected element

Categories

(DevTools :: Inspector, enhancement, P3)

Product:
DevTools
Component:
Inspector
Type:
enhancement

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

1390721.patch [1.0]
3.54 KB, patch
bgrins
: review+
Details | Diff | Splinter Review
No description provided.
Blocks: devtools-visual
Depends on: 1390727
Attached patch 1390721.patch (obsolete) — — Splinter Review
Attachment #8897694 - Flags: review?(bgrinstead)
Comment on attachment 8897694 [details] [diff] [review] 1390721.patch Review of attachment 8897694 [details] [diff] [review]: ----------------------------------------------------------------- This breaks the 'show all fonts' button on doctypes
Attachment #8897694 - Flags: review?(bgrinstead) → review-
Comment on attachment 8898488 [details] [diff] [review] 1390721.patch [1.0] Review of attachment 8898488 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/inspector/fonts/fonts.js @@ +142,3 @@ > > + // Clear the list of fonts if the currently selected node is not connected or an > + // element node unless all fonts are suppose to be shown. Nit: supposed
Attachment #8898488 - Flags: review?(bgrinstead) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/34d11e7339f3 Add a message when no fonts are found for the currently selected element. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/34d11e7339f3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
Component: Inspector: Fonts → Inspector
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: